Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#482 - Support partial property mappings #500

Merged
merged 2 commits into from
Feb 26, 2019
Merged

#482 - Support partial property mappings #500

merged 2 commits into from
Feb 26, 2019

Conversation

schillic
Copy link
Member

Closes #482.

There are also two bugfixes here. Property checking in the hybrid setting did not work at all 😲

  1. The call to check a property has changed recently, but was not updated here.
  2. Properties given as mappings "location index → property" were accessed with the location itself (instead of the index).

@schillic schillic requested a review from mforets February 26, 2019 08:32
@schillic schillic merged commit cfbbbfd into master Feb 26, 2019
@schillic schillic deleted the schillic/482 branch February 26, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support partial property mappings
2 participants
@schillic @mforets