#474 - Revise properties #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
force-pushed
the
schillic/474_part2
branch
from
3292cf4 to
1d3b958
Compare
schillic
force-pushed
the
schillic/474_part2
branch
from
1d3b958 to
7a7b32e
Compare
mforets
reviewed
Feb 24, 2019
mforets
reviewed
Feb 24, 2019
| Every concrete subtype should provide the following function: | ||
| - `check(𝑃::Property, X::LazySet)::Bool` | ||
| """ | ||
| abstract type Property end |
There was a problem hiding this comment.
Should it be called AbstractProperty?
There was a problem hiding this comment.
I'll merge. We can revise later.
mforets
reviewed
Feb 24, 2019
mforets
reviewed
Feb 24, 2019
mforets
approved these changes
Feb 24, 2019
mforets
reviewed
Feb 24, 2019
Co-Authored-By: schillic <[email protected]>
mforets
approved these changes
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #474.
check_property(::LazySet, ::Property)→check(::Property, ::LazySet)IntersectionProperty(was inverted)Conjunction/DisjunctionLinearConstraintPropertySubsetProperty→SafeStatesPropertyandIntersectionProperty→BadStatesProperty