Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#436 - Use AbstractMap interface in hybrid models #439

Merged
merged 2 commits into from
Feb 11, 2019
Merged

#436 - Use AbstractMap interface in hybrid models #439

merged 2 commits into from
Feb 11, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 2, 2019 •
edited
Loading

Closes #436.

@schillic schillic requested a review from mforets February 2, 2019 19:43
@schillic
Copy link
Member Author

schillic commented Feb 2, 2019 •
edited
Loading

The build error is because IdentityMap from MathematicalSystems is not known yet. Locally with the master version all tests pass.

@schillic
Copy link
Member Author

schillic commented Feb 2, 2019 •
edited
Loading

MathematicalSystems.AbstractMap must be imported explicitly because it is currenlty not exported from there.

@schillic schillic mentioned this pull request Feb 2, 2019
Closed
@schillic schillic mentioned this pull request Feb 9, 2019
Merged
@schillic
Copy link
Member Author

schillic commented Feb 10, 2019 •
edited
Loading

The build errors are because the new versions of HybridSystems and MathematicalSystems are currently not found on METADATA.

@schillic schillic merged commit a02b8c2 into master Feb 11, 2019
@schillic schillic deleted the schillic/436 branch February 11, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets