Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for julia v0.6 #431

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Drop support for julia v0.6 #431

merged 3 commits into from
Jan 30, 2019

Conversation

mforets
Copy link
Member

@mforets mforets commented Jan 30, 2019

No description provided.

schillic
schillic approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not remove the VERSION checks all over the code as well? Or at least open an issue.

@mforets
Copy link
Member Author

mforets commented Jan 30, 2019

Definitely. I can do it in this branch too.

schillic
schillic approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this hard work gone 😭

@schillic schillic merged commit cf1fd85 into master Jan 30, 2019
@schillic schillic deleted the mforets/dropv6 branch January 30, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic