Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP #255 - Refactor options #389

Closed
wants to merge 4 commits into from
Closed

WIP #255 - Refactor options #389

wants to merge 4 commits into from

Conversation

mforets
Copy link
Member

@mforets mforets commented Nov 1, 2018 •
edited
Loading

Requires #430.

@mforets
Copy link
Member Author

mforets commented Jan 30, 2019 •
edited
Loading

I think that we definitely have to separate those algorithm-specific methods and those which are generic. But i'm less sure that it is convenient to have an Options module for this purpose.

Let's rename options.jl -> Options.jl for the options, type, as usual. Then separate those functions which are specific for the decomp method into its own folder (see #430).

@mforets
Copy link
Member Author

mforets commented Jan 31, 2019

Closing in favor of #432.

@mforets mforets closed this Jan 31, 2019
@mforets mforets deleted the mforets/255 branch January 31, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mforets