Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise violation index in check mode #481

Open
schillic opened this issue Feb 21, 2019 · 0 comments
Open

Revise violation index in check mode #481

schillic opened this issue Feb 21, 2019 · 0 comments

Comments

@schillic
Copy link
Member

Follow-up of #473.
We currently return the index of a violation in the continuous-post algorithm.
However, in the hybrid setting, after the first jump, the index will start from 1 again. So instead, we should also add the previous time steps.

Actually, returning an index is not very general, as this relies on a fixed time step for the whole analysis. I suggest that we instead return a time interval. This would also simplify the refactoring for the above approach, as it would not depend on the time step anymore: if the continuous-post algorithm returns a time interval, this can just be added to the time interval of when the analysis was triggered from the hybrid loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant