Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better plotting in docs #169

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Better plotting in docs #169

merged 1 commit into from
Apr 10, 2024

Conversation

schillic
Copy link
Member

@schillic schillic commented Mar 7, 2024

In Julia v11 the old version actually stalls indefinitely.

@schillic schillic marked this pull request as ready for review March 7, 2024 11:35
@lucaferranti
Copy link
Member

interesting. Why is that? I dont think we do anything fancy here. I am wondering whether this would accept a bunch of other packages as well

@schillic
Copy link
Member Author

schillic commented Mar 7, 2024

Well, we saved and loaded the file again. This is of course redundant because there is a rendering engine. Normally I just return the figure object that is generated. Not sure how many packages would do this extra (redundant) step, which is also slower (requires disk access).

@schillic schillic merged commit b51f64b into master Apr 10, 2024
7 checks passed
@schillic schillic deleted the schillic/plots branch April 10, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants