Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#599 - Set membership for VPolytope #999

Merged
merged 4 commits into from
Jan 19, 2019
Merged

#599 - Set membership for VPolytope #999

merged 4 commits into from
Jan 19, 2019

Conversation

schillic
Copy link
Member

Closes #599.

@schillic schillic requested a review from mforets January 13, 2019 12:52
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

I left some comments below.

src/VPolytope.jl Outdated Show resolved Hide resolved
src/VPolytope.jl Show resolved Hide resolved
src/VPolytope.jl Outdated Show resolved Hide resolved
src/VPolytope.jl Outdated Show resolved Hide resolved
src/VPolytope.jl Show resolved Hide resolved
@schillic
Copy link
Member Author

Happy with the new commit?

Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👌 👌

@schillic schillic merged commit adb8618 into master Jan 19, 2019
@schillic schillic deleted the schillic/599 branch January 19, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants