Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#974 - tohrep and tovrep do not preserve numeric type #985

Merged
merged 5 commits into from
Jan 13, 2019
Merged

#974 - tohrep and tovrep do not preserve numeric type #985

merged 5 commits into from
Jan 13, 2019

Conversation

schillic
Copy link
Member

@schillic schillic commented Jan 10, 2019 •
edited
Loading

Closes #974.
Closes #994.

@schillic schillic requested a review from mforets January 10, 2019 19:59
mforets
mforets reviewed Jan 10, 2019
View reviewed changes
src/HPolyhedron.jl Outdated Show resolved Hide resolved
@mforets
Copy link
Member

mforets commented Jan 12, 2019

The error is because polyhedron makes an implicit conversion Rational{Int} -> Rational{BigInt}.

I'm doubting about my comment here. Actually, if solver needs more space to produce a correct result, then why wouldn't it use it? For sure i wouldn't convert back from Float64 -> Float32, or Rational{BigInt} -> Rational{Int}, say.

@schillic schillic requested a review from mforets January 12, 2019 17:59
mforets
mforets approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schillic schillic merged commit 9bc8dcb into master Jan 13, 2019
@schillic schillic deleted the schillic/974 branch January 13, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets