-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#964 - Check if polytope is bounded on construction #978
Conversation
Here i have an API / aesthetic concern: i see no need to add a new method |
We need it because |
Ok. What about the keyword in the constructor? I slightly prefer |
1343cd8
to
61bdb8f
Compare
182b9e2
to
4b2a9e2
Compare
4b2a9e2
to
46e9569
Compare
The last two commits are new. Can you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #964.