Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#973 - Use numeric / vector / matrix conventions #977

Merged
merged 4 commits into from
Jan 10, 2019
Merged

Conversation

schillic
Copy link
Member

@schillic schillic commented Jan 8, 2019

Closes #973.

I also took the liberty to add some more where conventions 😈

The only type parameter for a matrix is in LinearMap, but there is also the numeric type NM and then I found it confusing to also use MN.

@schillic schillic requested a review from mforets January 8, 2019 19:02
@schillic
Copy link
Member Author

schillic commented Jan 8, 2019

I also updated the guidelines. Should we rename them (because these guidelines were not about documentation)?

@mforets
Copy link
Member

mforets commented Jan 9, 2019

I also updated the guidelines. Should we rename them (because these guidelines were not about documentation)?

Great! The JuliaReachDevDocs repo is up and running, and I opened this issue there to remember incorporating your latest changes. (We can as well delete the wiki in LazySets.)

Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 ✅

@schillic schillic merged commit 82fb151 into master Jan 10, 2019
@schillic schillic deleted the schillic/973 branch January 10, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants