#972 - Subset check in polyhedron

[schillic]

Closes #972.

A unit test currently fails due to #974. This will automatically be resolved by merging #958 first.

[mforets]

This will automatically be resolved by merging #958 first.

Did you mean #958 or it was a typo? In schillic/416 i still get that tohrep(P) from #974 returns a HPolytope{Float64}.

[schillic]

In schillic/416 i still get that tohrep(P) from #974 returns a HPolytope{Float64}.

Sure, but the failing test here is a Zonotope → HPolytope conversion (this one).

[mforets]

LGTM.

There is an issue reported by CI that we should fix though:

LazySets.Polytope: Error During Test
  Test threw an exception of type MethodError
  Expression: BallInf(N[0, 0], N(1.01)) ⊈ P
  MethodError: no method matching ⊈(::LazySets.BallInf{Float64}, ::LazySets.HPolytope{Float64})
  Stacktrace:
   [1] eval_comparison(::Expr, ::Expr) at ./test.jl:198
   [2] macro expansion at /home/travis/.julia/v0.6/LazySets/test/unit_Polytope.jl:107 [inlined]
   [3] anonymous at ./<missing>:?
   [4] include_from_node1(::String) at ./loading.jl:576
   [5] include(::String) at ./sysimg.jl:14
   [6] macro expansion at /home/travis/.julia/v0.6/LazySets/test/runtests.jl:82 [inlined]
   [7] macro expansion at ./test.jl:860 [inlined]
   [8] macro expansion at ./util.jl:237 [inlined]
   [9] macro expansion at /home/travis/.julia/v0.6/LazySets/test/runtests.jl:82 [inlined]
   [10] anonymous at ./<missing>:?

[mforets]

Strangely enough, ⊈ works in 1.0 but not in 0.6, if i checkout this branch:

v.1.0

julia> N = Float64
Float64

julia> P = rand(VPolytope)
VPolytope{Float64}(Array{Float64,1}[[-1.42147, -1.23376], [0.769873, 1.68362], [1.03484, -0.991754], [1.92539, -0.605125], [-1.16005, -0.990606], [0.438257, 0
.598263]])

julia> BallInf(N[0, 0], N(1)) ⊆ P
false

julia> BallInf(N[0, 0], N(1.01)) ⊈ P
true

v0.6

julia> using LazySets, Polyhedra
INFO: Recompiling stale cache file /Users/forets/.julia/lib/v0.6/LazySets.ji for module LazySets.
WARNING: Method definition __init__() in module LazySets at /Users/forets/.julia/v0.6/Requires/src/init.jl:9 overwritten at /Users/forets/.julia/v0.6/Requires
/src/init.jl:9.

julia> N = Float64
Float64

julia> P = rand(VPolytope)
LazySets.VPolytope{Float64}(Array{Float64,1}[[0.636787, -0.155192], [-0.116778, -0.27157], [-1.2512, 0.794358]])

julia> BallInf(N[0, 0], N(1)) ⊆ P
false

julia> BallInf(N[0, 0], N(1.01)) ⊈ P
ERROR: MethodError: no method matching ⊈(::LazySets.BallInf{Float64}, ::LazySets.VPolytope{Float64})

[schillic]

Strangely enough, ⊈ works in 1.0 but not in 0.6

Yeah, meanwhile we have #1033 for that.