Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#943 - Update convexhull #944

Merged
merged 6 commits into from
Dec 18, 2018
Merged

#943 - Update convexhull #944

merged 6 commits into from
Dec 18, 2018

Conversation

mforets
Copy link
Member

@mforets mforets commented Dec 17, 2018

Closes #943.

Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wait for the answer in Polyhedra. If this is removal is performed internally, there is no need to do it again on our end.

@mforets
Copy link
Member Author

mforets commented Dec 17, 2018

It is intended that removevredundnacy! is used outside convexhull, so i suggest to use this branch after we figure what was is making it to fail.

@mforets
Copy link
Member Author

mforets commented Dec 18, 2018

Ok, found the error: the problem explained in the commented part seems to be fixed now:

        # Note: The redundant vertex v5 is not removed (see #561).
        # This test can be removed (and the length above should be corrected)
        # when that issue is resolved.
        @test length(vl) == 5 && v5  vl

Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this will not be fixed upstream, so we have to do it on our end.

test/unit_Polytope.jl Outdated Show resolved Hide resolved
src/HPolyhedron.jl Outdated Show resolved Hide resolved
@schillic
Copy link
Member

schillic commented Dec 18, 2018

I added above that this PR closes #561, but now I see that there is a second issue there.

the constructor of VPolytope does not remove redundant vertices.

I will hence add an optional argument removeredundancy::Bool=true to the default constructor.

EDIT: On second thought, there is more to do, so to keep this PR small, we can do that in another PR.

@mforets mforets merged commit 5d89265 into master Dec 18, 2018
@schillic schillic deleted the mforets/943 branch December 18, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants