-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#943 - Update convexhull #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would wait for the answer in Polyhedra
. If this is removal is performed internally, there is no need to do it again on our end.
It is intended that |
Ok, found the error: the problem explained in the commented part seems to be fixed now: # Note: The redundant vertex v5 is not removed (see #561).
# This test can be removed (and the length above should be corrected)
# when that issue is resolved.
@test length(vl) == 5 && v5 ∈ vl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this will not be fixed upstream, so we have to do it on our end.
I added above that this PR closes #561, but now I see that there is a second issue there.
I will hence add an optional argument EDIT: On second thought, there is more to do, so to keep this PR small, we can do that in another PR. |
Closes #943.