-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#930 - Define issubset for EmptySet #931
Conversation
f960998
to
eba8476
Compare
end | ||
|
||
# disambiguity | ||
function ⊆(∅::EmptySet{N}, H::AbstractHyperrectangle{N}, witness::Bool=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, why is that EmptySet
is ambiguous with AbstractHyperrectangle
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method
⊆(∅::EmptySet{N}, S::LazySet{N})
is ambiguous with
⊆(S::LazySet{N}, H::AbstractHyperrectangle{N})
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks. I wonder if Julia has some mechanism to ease this workaround, like allowing to invoke a given method. Maybe with invoke.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, but invoke
is less efficient, which is why I try to avoid it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less efficient in which sense? The call overhead should be negligible, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not if you call this function very often. In this case I agree, though.
eba8476
to
f7435f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #930.
box_approximation(∅)