Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#930 - Define issubset for EmptySet #931

Merged
merged 3 commits into from
Nov 29, 2018
Merged

#930 - Define issubset for EmptySet #931

merged 3 commits into from
Nov 29, 2018

Conversation

schillic
Copy link
Member

@schillic schillic commented Nov 28, 2018

Closes #930.

  • ∅ ⊆ X
  • X ⊆ ∅
  • box_approximation(∅)

end

# disambiguity
function ⊆(∅::EmptySet{N}, H::AbstractHyperrectangle{N}, witness::Bool=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, why is that EmptySet is ambiguous with AbstractHyperrectangle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method
⊆(∅::EmptySet{N}, S::LazySet{N})
is ambiguous with
⊆(S::LazySet{N}, H::AbstractHyperrectangle{N}).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks. I wonder if Julia has some mechanism to ease this workaround, like allowing to invoke a given method. Maybe with invoke.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but invoke is less efficient, which is why I try to avoid it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less efficient in which sense? The call overhead should be negligible, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not if you call this function very often. In this case I agree, though.

@schillic schillic changed the title WIP #930 - Define issubset for EmptySet #930 - Define issubset for EmptySet Nov 28, 2018
@schillic schillic requested a review from mforets November 28, 2018 15:44
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schillic schillic merged commit bc95ece into master Nov 29, 2018
@schillic schillic deleted the schillic/930 branch November 29, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants