#918 - vertices_list for AbstractHPolygon with infeasible constraints is incorrect #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
Nov 17, 2018
| @@ -109,6 +123,15 @@ function vertices_list(P::AbstractHPolygon{N}, | |||
| end | |||
| points[n] = element(intersection(Line(P.constraints[n]), | |||
| Line(P.constraints[1]))) | |||
|
|
|||
| # check if polygon was empty | |||
There was a problem hiding this comment.
did you forget to use the flag check_feasibility below?
mforets
reviewed
Nov 17, 2018
src/AbstractHPolygon.jl
Outdated
|
|
||
| # check if polygon was empty | ||
| avg = sum(points) / length(points) | ||
| for c in constraints_list(P) |
There was a problem hiding this comment.
note that one could ask for (see this function):
if avg ∉ P
return Vector{Vector{N}}(undef, 0)
end
schillic
force-pushed
the
schillic/918
branch
from
3715030 to
25758ae
Compare
|
Thanks, I rebased. |
mforets
approved these changes
Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #918.