Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#849 - Generalize default implementation of isdisjoint #850

Merged
merged 4 commits into from
Oct 25, 2018
Merged

#849 - Generalize default implementation of isdisjoint #850

merged 4 commits into from
Oct 25, 2018

Conversation

schillic
Copy link
Member

Closes #849.

@schillic schillic requested a review from mforets October 24, 2018 21:28
@schillic schillic force-pushed the schillic/849 branch 2 times, most recently from a8120ef to 4ab88c1 Compare October 25, 2018 07:32
mforets
mforets approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

the last two is_intersection_empty methods do not admit the witness flag. perhaps could be added as well.

@schillic
Copy link
Member Author

Yeah, I want to revise that stuff soon, for now let me merge it.

@schillic schillic merged commit 2aecd13 into master Oct 25, 2018
@schillic schillic deleted the schillic/849 branch October 25, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets