Dimension error for default Polyhedra backend in >= v0.7 #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
approved these changes
Oct 24, 2018
| @@ -148,12 +148,12 @@ else | |||
| points, | |||
| default_library | |||
|
|
|||
| function default_polyhedra_backend(N::Type{<:AbstractFloat}) | |||
| return default_library(2, Float64) | |||
| function default_polyhedra_backend(P, N::Type{<:AbstractFloat}) | |||
There was a problem hiding this comment.
Suggested change
| function default_polyhedra_backend(P, N::Type{<:AbstractFloat}) | |
| function default_polyhedra_backend(P::HPoly, N::Type{<:AbstractFloat}) |
There was a problem hiding this comment.
i had this, but then removed because HPoly is not yet defined at this place :/
There was a problem hiding this comment.
But you have it for the other methods, see here...
There was a problem hiding this comment.
Indeed you have to remove it there:
Got an exception of type LoadError outside of a @test
LoadError: no default backend for numeric type Float64
Stacktrace:
[1] default_polyhedra_backend(::LazySets.VPolytope{Float64}, ::Type{T} where T) at /home/travis/.julia/v0.6/LazySets/src/AbstractPolytope.jl:112
schillic
approved these changes
Oct 24, 2018
|
There is still a problem with the cartesian product (using the default library), that i have reported upstream: JuliaPolyhedra/Polyhedra.jl#132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #842.
This PR adds P to the default_polyhedra_backend.