#397 Add cache to Intersection #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
force-pushed
the
schillic/397
branch
2 times, most recently
from
59c3f6b to
8a475ae
Compare
mforets
reviewed
Oct 14, 2018
src/Intersection.jl
Outdated
| """ | ||
| function isempty(cap::Intersection)::Bool | ||
| return is_intersection_empty(cap.X, cap.Y) | ||
| if isempty_known(cap.cache) |
There was a problem hiding this comment.
above there is a method isempty_konwn(::Intersection). should we use it instead? (or delete it?)
mforets
approved these changes
Oct 14, 2018
schillic
force-pushed
the
schillic/397
branch
from
8a475ae to
b6f027c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #397.