#781 - Intersection emptiness check for two half-spaces #782

schillic · 2018-10-13T15:20:50Z

Closes #781.

mforets

lgtm, nicely done!

i had some doubts about the type instability in samedir (not using zero(N) etc).

if you approve my changes i think it is good to merge.

schillic · 2018-10-14T09:28:38Z

i had some doubts about the type instability in samedir (not using zero(N) etc).

Yes, but if you have 1 / 2 (of type Int), then the result will be a Float64. The implementation will anyway not work due to numerical issues. We should maybe add a general way to specify a tolerance.

mforets · 2018-10-14T09:30:09Z

i agree; using N<:AbstractFloat seems reasonable in those cases too.

schillic added 2 commits October 13, 2018 17:19

add function 'samedir'

1d52f3d

add isdisjoint for two half-spaces

08acf67

schillic requested a review from mforets October 13, 2018 16:58

review 781

6d003ea

mforets approved these changes Oct 14, 2018

View reviewed changes

schillic merged commit 53b778c into master Oct 14, 2018

schillic deleted the schillic/781 branch October 14, 2018 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#781 - Intersection emptiness check for two half-spaces #782

#781 - Intersection emptiness check for two half-spaces #782

schillic commented Oct 13, 2018

mforets left a comment

schillic commented Oct 14, 2018

mforets commented Oct 14, 2018

#781 - Intersection emptiness check for two half-spaces #782

#781 - Intersection emptiness check for two half-spaces #782

Conversation

schillic commented Oct 13, 2018

mforets left a comment

Choose a reason for hiding this comment

schillic commented Oct 14, 2018

mforets commented Oct 14, 2018