Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias 'isdisjoint' for 'is_intersection_empty' #655

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

schillic
Copy link
Member

No description provided.

@schillic schillic requested a review from mforets September 24, 2018 13:28
@schillic schillic changed the title Ddd alias 'disjoint' for 'is_intersection_empty' Add alias 'disjoint' for 'is_intersection_empty' Sep 24, 2018
@mforets
Copy link
Member

mforets commented Sep 24, 2018

I would rather expect is_disjoint (or isdisjoint), becuse of the boolean output.
But i agree to keep disjoint, since we don't have another meaning for it.

@schillic
Copy link
Member Author

I also thought about this. It could also be aredisjoint, which I find unusual.

@schillic
Copy link
Member Author

I would rather expect is_disjoint (or isdisjoint), becuse of the boolean output.

On second thought, I will change it. Two sets are disjoint, but the first set is disjoint from the second set 👍

@schillic schillic changed the title Add alias 'disjoint' for 'is_intersection_empty' Add alias 'isdisjoint' for 'is_intersection_empty' Sep 24, 2018
@schillic schillic merged commit a748e1b into master Sep 24, 2018
@schillic schillic deleted the schillic/disjoint branch September 24, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants