#473 - Convert AbstractHyperrectangle to HPolytope #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
approved these changes
Sep 10, 2018
src/AbstractHyperrectangle.jl
Outdated
| function constraints_list(H::AbstractHyperrectangle{N})::Vector{LinearConstraint{N}} where {N<:Real} | ||
| n = dim(H) | ||
| constraints = Vector{LinearConstraint{N}}(2*n) | ||
| A, b, c = eye(n), high(H), -low(H) |
There was a problem hiding this comment.
It is cheaper to create the row vectors of A individually. You could use UnitVector, see #538.
schillic
approved these changes
Sep 11, 2018
src/AbstractHyperrectangle.jl
Outdated
| b, c = high(H), -low(H) | ||
|
|
||
| for i in 1:n | ||
| ei = LazySets.Approximations.UnitVector(i, n, 1.0) |
|
ready from my side |
mforets
commented
Sep 11, 2018
test/unit_Polytope.jl
Outdated
| P = convert(HPolytope, H1) | ||
| vlist = vertices_list(P) | ||
| @test length(vlist) == 4 | ||
| @test all([vi ∈ vlist for vi in [N[3, 3], N[3, -1], N[-1, -1], N[-1, 3]]]) |
There was a problem hiding this comment.
i added this test here because the conversion and testing for vertices requires to load the package Polyhedra
There was a problem hiding this comment.
You have to add a condition that Polyhedra is loaded around this test:
if test_suite_polyhedra
Otherwise, vertices_list is not defined and the test crashes.
schillic
approved these changes
Sep 11, 2018
schillic
reviewed
Sep 11, 2018
test/unit_Polytope.jl
Outdated
| @@ -56,6 +56,13 @@ for N in [Float64, Rational{Int}, Float32] | |||
| @test length(p.constraints) == length(cl) | |||
| end | |||
|
|
|||
| # convert a hyperrectangle to a HPolytope | |||
| H = Hyperrectangle(N[1, 1], N[2, 2]) | |||
| P = convert(HPolytope, H1) | |||
schillic
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #473.
AbstractHyperrectangleAbstractHyperrectangletoHPolytopeHPolygon