-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge recipes for polygons and add polytopes #602
Conversation
Why not just use |
You also need to adapt the unit tests in |
Yeah you're right, i agree to plot every |
I had a look, but what is there to change? I wouldn't delete tests even if they are now called from the same recipe. (since for each different type they are testing different code paths) |
src/plot_recipes.jl
Outdated
|
||
""" | ||
plot_polygon(P::Union{AbstractPolygon, HPolytope, VPolytope}; ...) | ||
plot_polygon(P::Union{AbstractPolytope}; ...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without Union
(same below)
Yes.
You may need to replace the |
Closes #574.