#92 - Better calculation of list of vertices for degenerate centrally symmetric polytopes #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
changed the title
mforets
changed the title
schillic
requested changes
Aug 28, 2018
src/AbstractHyperrectangle.jl
Outdated
| @@ -51,6 +51,10 @@ For high dimensions, it is preferable to develop a `vertex_iterator` approach. | |||
| """ | |||
| function vertices_list(H::AbstractHyperrectangle{N} | |||
| )::Vector{Vector{N}} where {N<:Real} | |||
| # fast evaluation if B has radius 0 | |||
| if contains(==, radius_hyperrectangle(H), zero(N)) | |||
There was a problem hiding this comment.
I do not understand this check. I would expect
vertices_list(Hyperrectangle([1., 1.], [0., 1.]) == [[1., 0.], [1., 2.]].
For me, the check should be radius_hyperrectangle(H) == zeros(N, dim(H)).
(The unit test has to be adapted accordingly.)
There was a problem hiding this comment.
If this was referring to this comment, I meant that the result should contain less than 2^n vertices.
schillic
reviewed
Aug 28, 2018
test/unit_Hyperrectangle.jl
Outdated
| # check that vertices_list is computed correctly if the hyperrectangle | ||
| # is "degenerate" in the sense that its radius is zero in at least one dimension | ||
| # this test would take very long if all 2^100 vertices are computed (see #92) | ||
| H = Hyperrectangle(fill(N(1.), 100), [fill(N(2.), 99); 0.]) |
There was a problem hiding this comment.
Apparently, you need to write N(0.) again. Otherwise it will make the whole vector a Float64.
|
thanks for the feedback! |
|
Should we add a unit test for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92.