Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use technical term 'centrally symmetric' for 'point symmetric' #588

Merged
merged 2 commits into from
Aug 24, 2018

Conversation

schillic
Copy link
Member

According to Wikipedia, what I called point symmetry is weaker than central symmetry:

An object that is invariant under a point reflection is said to possess point symmetry; if it is invariant under point reflection through its center, it is said to possess central symmetry or to be centrally symmetric.

@mforets:
Should we clarify by merging this PR?
Should we also rename the interfaces?

@schillic schillic requested a review from mforets August 24, 2018 06:57
@mforets
Copy link
Member

mforets commented Aug 24, 2018

Should we clarify by merging this PR?

ok

Should we also rename the interfaces?

👍 , those interfaces have a center(...) method, so i think it is good to use Centrally in their names.

@schillic
Copy link
Member Author

I renamed the interfaces, good to merge from my side!

@mforets mforets merged commit fb6e1c9 into master Aug 24, 2018
@mforets mforets deleted the schillic/pointsymmetricset branch August 24, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants