Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#121 - Add undef and revise polytope/polygon constructors #495

Merged
merged 5 commits into from
Aug 8, 2018

Conversation

schillic
Copy link
Member

@schillic schillic commented Aug 8, 2018

See #121.

  • add undef as commented here and here
  • revise initialization of polytope/polygon constructors from empty input; also fix the constructor for VPolytope
  • add constructors for VPolygon
  • revise initialization of array set type constructors from empty input

@schillic schillic requested a review from mforets August 8, 2018 11:41
@schillic
Copy link
Member Author

schillic commented Aug 8, 2018

Actually, there are more places:

AbstractHPolygon.jl:    points = Vector{Vector{N}}(n)
AbstractPolytope.jl:    new_vlist = Vector{Vector{N}}(length(vlist))
CartesianProduct.jl:    arr = Vector{LazySet{N}}(0)
convert.jl:    constraints_list = Vector{LinearConstraint{N}}(3)
ConvexHull.jl:    a = Vector{LazySet{N}}(0)
Intersection.jl:    arr = Vector{LazySet{N}}(0)
MinkowskiSum.jl:    arr = Vector{LazySet{N}}(0)
MinkowskiSum.jl:    arr = Vector{LazySet{N}}(0)
VPolygon.jl:        constraints_list = Vector{LinearConstraint{N}}(0)

@schillic
Copy link
Member Author

schillic commented Aug 8, 2018

I found a last one in to_N.jl: Matrix{N}(k) is of course also affected. I rebased.

@schillic schillic merged commit 74bc3aa into master Aug 8, 2018
@schillic schillic deleted the schillic/undef branch August 8, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants