Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assertions for input error checks #392

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Use assertions for input error checks #392

merged 1 commit into from
Jul 26, 2018

Conversation

schillic
Copy link
Member

@schillic schillic commented Jul 23, 2018 •
edited
Loading

Motivation: It should be possible to deactivate input checks in favor of performance. This is possible with @assert (see #70).

@schillic schillic requested a review from mforets July 23, 2018 18:54
mforets
mforets approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

@schillic schillic mentioned this pull request Jul 23, 2018
Merged
9 tasks
@schillic schillic force-pushed the schillic/70 branch 2 times, most recently from c7c04d9 to 6da1fea Compare July 25, 2018 19:50
@schillic schillic merged commit e16cd80 into master Jul 26, 2018
@schillic schillic deleted the schillic/70 branch July 26, 2018 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets