Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distance between EmptySets #3723

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fix distance between EmptySets #3723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Sets/EmptySet/distance.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@ end
function _distance_emptyset(∅::EmptySet, X::LazySet; p::Real=2.0)
@assert dim(∅) == dim(X) "the dimensions of the given sets should match, " *
"but they are $(dim(∅)) and $(dim(X)), respectively"
throw(ArgumentError("the distance to an empty set is undefined"))

N = promote_type(eltype(∅), eltype(X))
return N(Inf)
end
3 changes: 2 additions & 1 deletion test/Sets/EmptySet.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ for N in [Float64, Rational{Int}, Float32]
@test E2 isa BallInf{N} && E2 == B

# distance
@test_throws ArgumentError distance(E, E)
res = distance(E, E)
@test res isa N && res == N(Inf)
E2 = EmptySet{N}(3)
@test_throws AssertionError distance(E, E2)
@test_throws AssertionError distance(E2, E)
Expand Down
Loading