Line2D: merge docs, remove method from HalfSpace #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
force-pushed
the
schillic/Line2D
branch
from
128c1b6 to
3dc62b2
Compare
schillic
force-pushed
the
schillic/Line2D
branch
from
3dc62b2 to
c336231
Compare
schillic
force-pushed
the
schillic/Line2D
branch
from
c336231 to
0d07cee
Compare
mforets
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line2D(::HalfSpace)because this is part of the public API and it is unclear what that means. It was exclusively used to intersect 2D polygon edges represented asHalfSpaces. Instead I added an internal method, which even avoids the conversion toLine2D.