Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3203 - Make rand of HParallelotope return a nonempty set #3221

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

schillic
Copy link
Member

Closes #3203.

There is a small chance that the result is unbounded (this was also possible before).

julia> D = [1. 1; 1 1];
julia> offset = [1., 1, -1, -1];
julia> Q = HParallelotope(D, offset);
julia> P = HPolyhedron(vcat(Q.directions, -Q.directions), Q.offset);  # convert to polyhedron
julia> isbounded(P)
false

@schillic schillic marked this pull request as ready for review December 16, 2022 22:01
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could otherwise iterate until the set obtained is bounded.

@schillic schillic requested a review from mforets February 20, 2023 06:25
@schillic schillic merged commit 4b7b02d into master Feb 24, 2023
@schillic schillic deleted the schillic/3203 branch February 24, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random parallelotope generation often returns an empty set
2 participants