Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise ExponentialMap code #3189

Merged
merged 2 commits into from
Nov 13, 2022
Merged

Revise ExponentialMap code #3189

merged 2 commits into from
Nov 13, 2022

Conversation

schillic
Copy link
Member

@schillic schillic commented Nov 5, 2022

The first commit revises the code, with the only change being that ExponentialMap of an EmptySet now correctly changes the dimension (as for the ZeroSet).
The second commit outsources ExponentialProjectionMap to its own file.

@schillic schillic force-pushed the schillic/exponentialmap branch from 4b40091 to 9edda82 Compare November 5, 2022 18:31
@schillic schillic mentioned this pull request Nov 5, 2022
Closed
@schillic schillic marked this pull request as ready for review November 5, 2022 19:14
@schillic schillic requested a review from mforets November 5, 2022 19:14
@schillic schillic merged commit 5d50e8f into master Nov 13, 2022
@schillic schillic deleted the schillic/exponentialmap branch November 13, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets