Revise issubset code and generalize to LazySet #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
force-pushed
the
schillic/issubset
branch
4 times, most recently
from
8934e0c to
3791570
Compare
schillic
force-pushed
the
schillic/issubset
branch
from
3791570 to
4bcc351
Compare
mforets
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1856.
The main code changes are:
_issubset_in_hyperrectanglenow does not requireinterval_hullanymore (and is also more efficient)_default_issubsetfunction because it was only used by one method.⊆(::LazySet, ::UnionSetArray).The second commit adds
is_polyhedralforBloatingto make an old test pass.