redefine eye, and add Cartesian indexing #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
reviewed
Mar 31, 2018
src/ExponentialMap.jl
Outdated
| @@ -61,7 +61,10 @@ end | |||
| SparseMatrixExp(M::Matrix{N}) where {N} = | |||
| error("only sparse matrices can be used to create a `SparseMatrixExp`") | |||
|
|
|||
| Base.eye(spmexp::SparseMatrixExp) = eye(spmexp.M) | |||
| Base.eye(spmexp::SparseMatrixExp) = SparseMatrixExp(zeros(spmexp.M)) | |||
There was a problem hiding this comment.
spzeros would be more efficient, right?
There was a problem hiding this comment.
spzeros(::SparseMatrixCSC) doesn't exist, but we can change it to Base.eye(spmexp::SparseMatrixExp) = SparseMatrixExp(spzeros(size(E.M)...)).
src/ExponentialMap.jl
Outdated
| Base.eye(spmexp::SparseMatrixExp) = SparseMatrixExp(zeros(spmexp.M)) | ||
|
|
||
| Base.IndexStyle(::Type{<:SparseMatrixExp}) = IndexCartesian() | ||
| Base.getindex(spmexp::SparseMatrixExp{N}, I::Vararg{Int, 2}) where {N} = get_column(spmexp, I[2])[I[1]] |
There was a problem hiding this comment.
I think you can omit the type N if you do not use it on the r.h.s.
schillic
reviewed
Mar 31, 2018
src/ExponentialMap.jl
Outdated
| @@ -61,10 +61,10 @@ end | |||
| SparseMatrixExp(M::Matrix{N}) where {N} = | |||
| error("only sparse matrices can be used to create a `SparseMatrixExp`") | |||
|
|
|||
| Base.eye(spmexp::SparseMatrixExp) = SparseMatrixExp(zeros(spmexp.M)) | |||
| Base.eye(spmexp::SparseMatrixExp) = SparseMatrixExp(spzeros(size(E.M)...)) | |||
added 2 commits
March 31, 2018 15:28
|
merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #308.