Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#306 - Revise SparseMatrixExp #307

Merged
merged 3 commits into from
Mar 29, 2018
Merged

#306 - Revise SparseMatrixExp #307

merged 3 commits into from
Mar 29, 2018

Conversation

mforets
Copy link
Member

@mforets mforets commented Mar 29, 2018 •
edited by schillic
Loading

Closes #306.

  • extend SparseMatrixExp examples
  • add constructor error for dense
  • add an example to ExponentialMap

schillic
schillic approved these changes Mar 29, 2018
View reviewed changes
src/ExponentialMap.jl Outdated
@@ -21,6 +21,33 @@ Type that represents the matrix exponential, ``\\exp(M)``, of a sparse matrix.

- `M` -- sparse matrix

### Examples

Take for exammple a random sparse matrix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a colon (:)?

src/ExponentialMap.jl Outdated

julia> get_rows(E, [10]); # same as get_row(E, 10) but a 1x100 matrix is returned

julia> get_columns(E, [10]); # same as get_row(E, 10) but a 100x1 matrix is returned
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"same as get_column"

@mforets
Copy link
Member Author

mforets commented Mar 29, 2018

thanks for the review.

@mforets mforets merged commit 1c79995 into master Mar 29, 2018
@mforets mforets deleted the mforets/306 branch March 29, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic