Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPZ conversions #3016

Merged
merged 6 commits into from
Aug 3, 2022
Merged

SPZ conversions #3016

merged 6 commits into from
Aug 3, 2022

Conversation

lucaferranti
Copy link
Member

@lucaferranti lucaferranti commented Aug 1, 2022

builds on top of #3015

implements conversion from Zonotope and SSPZ to SPZ and conversion from SPZ to SSPZ

@lucaferranti
Copy link
Member Author

lucaferranti commented Aug 1, 2022

wtf? didn't I add the missing docstrings?

@schillic
Copy link
Member

schillic commented Aug 1, 2022

You need to add the where {N} precisely as in the method. (This is annoying because here it is redundant.)

src/Sets/SparsePolynomialZonotope.jl Show resolved Hide resolved
src/convert.jl Outdated Show resolved Hide resolved
src/convert.jl Outdated Show resolved Hide resolved
src/convert.jl Outdated Show resolved Hide resolved
docs/src/lib/conversion.md Outdated Show resolved Hide resolved
@lucaferranti
Copy link
Member Author

lucaferranti commented Aug 1, 2022

why the heck does the doc check keep failing?

│     Base.convert :: Tuple{Type{SimpleSparsePolynomialZonotope}, SparsePolynomialZonotope}
│     Base.convert :: Tuple{Type{SimpleSparsePolynomialZonotope}, AbstractZonotope}

@lucaferranti
Copy link
Member Author

ah wait maybe I know

@schillic
Copy link
Member

schillic commented Aug 1, 2022

Yes, that should do it. I was confused that some method was old.

src/Sets/SparsePolynomialZonotope.jl Outdated Show resolved Hide resolved
@lucaferranti lucaferranti changed the title lf conversions SPZ conversions Aug 3, 2022
@schillic schillic merged commit d2873b5 into master Aug 3, 2022
@schillic schillic deleted the lf-conversions branch August 3, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants