change LazySet to ConvexSet #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The file I changed this PR to a draft to indicate that we should not yet merge it. |
I think this change will make the PR unnecessarily big, let's defer that to another PR? |
lucaferranti
requested review from
schillic and
mforets
and removed request for
schillic
schillic
reviewed
Jul 9, 2022
|
LGTM, thanks! I will approve next week after doing some other refactoring. We should also merge the other recently opened PRs before merging this PR, but I think they do not conflict. |
mforets
approved these changes
Jul 15, 2022
* check convexity in line segment * Update docs/src/lib/binary_functions.md * fix ambiguity * Update src/ConcreteOperations/issubset.jl Co-authored-by: Christian Schilling <[email protected]> * Update src/ConcreteOperations/issubset.jl Co-authored-by: Luca Ferranti <[email protected]> Co-authored-by: Christian Schilling <[email protected]> Co-authored-by: Luca Ferranti <[email protected]>
1 task
schillic
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref: #1895 (comment)
LazySet-->ConvexSetLazySetmake nonconvex sets subtypes offor upcoming PRLazySet- [ ] DensePolynomialZonotope
- [ ] SimpleSparsePolynomialZonotope
- [ ] UnionSet
- [ ] UnionSetArray
- [ ] Complement
- [ ] Rectification