Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quadratic map for sspz #2990

Merged
merged 5 commits into from
Jul 15, 2022
Merged

add quadratic map for sspz #2990

merged 5 commits into from
Jul 15, 2022

Conversation

lucaferranti
Copy link
Member

No description provided.

@lucaferranti lucaferranti requested review from schillic and mforets July 8, 2022 08:54
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not yet checked the actual algorithm.

src/Sets/SimpleSparsePolynomialZonotope.jl Show resolved Hide resolved
src/Sets/SimpleSparsePolynomialZonotope.jl Outdated Show resolved Hide resolved
src/Sets/SimpleSparsePolynomialZonotope.jl Outdated Show resolved Hide resolved
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The algorithm looks correct to me 👍

src/Sets/SimpleSparsePolynomialZonotope.jl Outdated Show resolved Hide resolved
Co-authored-by: Christian Schilling <[email protected]>
src/Sets/SimpleSparsePolynomialZonotope.jl Outdated Show resolved Hide resolved
@lucaferranti lucaferranti linked an issue Jul 11, 2022 that may be closed by this pull request
@lucaferranti lucaferranti requested review from mforets and removed request for mforets July 12, 2022 16:56
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/Sets/SimpleSparsePolynomialZonotope.jl Outdated Show resolved Hide resolved
@inbounds for i in 1:h
idxstart = h * i + 1
idxend = (i + 1) * h
Enew[:, idxstart:idxend] .+= E[:, i]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E[:, i] and in other places it allocates, we could optimize but i think it's fine for now.

@mforets mforets merged commit a12f64a into master Jul 15, 2022
@mforets mforets deleted the lf-qm branch July 15, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add quadratic map of SPZ
3 participants