linear combination and convex hull on sspz #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
reviewed
Jun 15, 2022
Co-authored-by: Christian Schilling <[email protected]>
|
For the docs error you need to add the two methods here and add a new block for |
schillic
approved these changes
Jun 16, 2022
|
@lucaferranti can you pls add some tests for the new functionality? |
mforets
reviewed
Jun 18, 2022
schillic
approved these changes
Jun 21, 2022
| @@ -32,4 +32,25 @@ for N in [Float64, Float32, Rational{Int}] | |||
| @test genmat(CPS) == [1 2 0 0;2 2 0 0;0 0 1 2;0 0 2 2.] | |||
| @test expmat(CPS) == [1 4 0 0;1 2 0 0;0 0 1 4;0 0 1 2] | |||
|
|
|||
| _c = N[2.0, 0.0] | |||
There was a problem hiding this comment.
It is okay now, but typically we do not use underscores for variables. Since we have the outer loops in the test files, there are usually no scoping problems.
mforets
reviewed
Jun 22, 2022
mforets
reviewed
Jun 22, 2022
mforets
reviewed
Jun 22, 2022
mforets
approved these changes
Jun 23, 2022
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.