Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operations on simple sparse polynomial zonotopes #2978

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Conversation

lucaferranti
Copy link
Member

@lucaferranti lucaferranti commented Jun 12, 2022

This PR adds the operations on SSPZ described in Niklas presentation. Currently I added those into the same file of SSPZ, but maybe we want to move those in the corresponding files in concrete_operations?

TODO

  • linear combination in future PR
  • quadratic map in future PR
  • convex hull in future PR
  • tests

@lucaferranti lucaferranti marked this pull request as ready for review June 14, 2022 09:00
@lucaferranti lucaferranti requested review from mforets and schillic June 14, 2022 09:02
@schillic
Copy link
Member

Looks good after moving the binary methods to the respective files 👍

@lucaferranti
Copy link
Member Author

Looks good after moving the binary methods to the respective files 👍

among the functions implemented here, it seems only cartesian_product and minkowski_sum have a corresponding file in ConcreteOperations, should I create a new file for linear_map or leave it under SimpleSparsePolynomialZonotope.jl ?

@schillic
Copy link
Member

linear_map is not binary and hence we keep it in the same file.

@lucaferranti
Copy link
Member Author

moved the files. Out of curiosity, does LazySets rely on promotion mechanisms or how should it handles things like e.g.

minkowski_sum(::SimpleSparsePolynomialZonotope, ::Star)

@schillic
Copy link
Member

moved the files. Out of curiosity, does LazySets rely on promotion mechanisms or how should it handles things like e.g.

minkowski_sum(::SimpleSparsePolynomialZonotope, ::Star)

That would require adding a specific method and is out of scope for now.

@lucaferranti
Copy link
Member Author

lucaferranti commented Jun 14, 2022

btw currently the following fails

linear_map(I, S)

where S is SSPZ, the reason for this is that I is UniformScaling and it's not a subtype of AbstractMatrix, that's arguably a pretty boring linear map to apply. Is it worth to change the signature for that?

@schillic
Copy link
Member

Is it worth to change the signature for that?

I do not think so.

@schillic schillic merged commit 76a5478 into master Jun 15, 2022
@schillic schillic deleted the lf-sspz-ops branch June 15, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants