Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2647 - Revise plot recipe for UnionSet #2653

Merged
merged 1 commit into from
Apr 13, 2021
Merged

#2647 - Revise plot recipe for UnionSet #2653

merged 1 commit into from
Apr 13, 2021

Conversation

schillic
Copy link
Member

Closes #2647.

  • The UnionSet and UnionSetArray recipe now just plots a sequence of sets with the same options (in particular the same color and a single label).
  • There was a plotting argument fast but using it was not comfortable, so I turned it into a keyword argument.
  • I also changed the name of the fast argument to same_recipe because that describes the effect better. That it is faster is a nice side effect but less important.

@schillic schillic force-pushed the schillic/2647 branch 2 times, most recently from febef46 to 6f077f8 Compare April 13, 2021 04:30
@schillic
Copy link
Member Author

schillic commented Apr 13, 2021

Plotting flat sets with this same_recipe option results in black line segments. This is because we do not set the line color by default and this plot recipe does not call the special "flat set" recipe. I suggest that we set the line color to the same color.

EDIT: We agreed that the border color should remain black by default. If needed one can use plot(...; same_recipe=true, linecolor=...).

@schillic schillic merged commit 97d0679 into master Apr 13, 2021
@schillic schillic deleted the schillic/2647 branch April 13, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise plot recipe for UnionSet
2 participants