Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1280 - Rotated hyperrectangle #2605

Merged
merged 3 commits into from
Mar 22, 2021
Merged

#1280 - Rotated hyperrectangle #2605

merged 3 commits into from
Mar 22, 2021

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 28, 2021

Closes #1280.

  • This implementation is not closed under translation. Maybe add another field offset?
  • tests
  • docs

The name RotatedHyperrectangle may be misleading. The matrix does not have to be a rotation matrix (not even invertible). I am open to suggestions.

@schillic schillic force-pushed the schillic/1280 branch 3 times, most recently from 0f7a0fd to 28a6b19 Compare February 28, 2021 21:21
@schillic schillic changed the title WIP #1280 - Rotated hyperrectangle #1280 - Rotated hyperrectangle Mar 17, 2021
@mforets
Copy link
Member

mforets commented Mar 18, 2021

The name RotatedHyperrectangle may be misleading. The matrix does not have to be a rotation matrix (not even invertible). I am open to suggestions.

The set is a special case of a lazy LinearMap. It a special case of a Star. In #2554 we implemented the new star set type and in #2578 we removed it and instead chose to use an alias for the lazy type instead of defining a new type. Perhaps we should do the same with the RotatedHyperrectangle.

@schillic
Copy link
Member Author

I had thought about this as well. The benefit of having it as a separate type is the functionality that comes with inheriting from AbstractZonotope. And it can be used in all methods that take an AbstractZonotope as input (for example in reachability algorithms).

@schillic schillic merged commit ef4476f into master Mar 22, 2021
@schillic schillic deleted the schillic/1280 branch March 22, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotated hyperrectangle / orthogonal polytope
2 participants