Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2521 - Concrete projection a hyperrectangular cartesian product #2524

Merged
merged 6 commits into from
Jan 28, 2021
Merged

#2521 - Concrete projection a hyperrectangular cartesian product #2524

merged 6 commits into from
Jan 28, 2021

Conversation

SebastianGuadalupe
Copy link
Member

Closes #2521.

schillic
schillic reviewed Jan 28, 2021
View reviewed changes
test/unit_CartesianProduct.jl Outdated Show resolved Hide resolved
src/LazyOperations/CartesianProduct.jl Outdated Show resolved Hide resolved
src/LazyOperations/CartesianProduct.jl Outdated Show resolved Hide resolved
src/LazyOperations/CartesianProduct.jl Outdated Show resolved Hide resolved
src/LazyOperations/CartesianProduct.jl Outdated Show resolved Hide resolved
mforets
mforets approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mforets mforets merged commit 00d75fd into master Jan 28, 2021
@mforets mforets deleted the sguadalupe/2521 branch January 28, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concrete projection a hyperrectangular cartesian product
3 participants
@SebastianGuadalupe @schillic @mforets