Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup issubset #2517

Merged
merged 2 commits into from
Jan 28, 2021
Merged

cleanup issubset #2517

merged 2 commits into from
Jan 28, 2021

Conversation

mforets
Copy link
Member

@mforets mforets commented Jan 25, 2021

No description provided.

@mforets
Copy link
Member Author

mforets commented Jan 25, 2021

the tests pass locally. the docstest failed, but i didn't get any hint of where it failed..

schillic
schillic approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is

UndefVarError: N not defined

Let us hope it was just this one 😅

docs/src/lib/binary_functions.md Outdated Show resolved Hide resolved
@mforets @schillic
Update docs/src/lib/binary_functions.md
a155cca 
Co-authored-by: Christian Schilling <[email protected]>
@mforets mforets merged commit b220dd4 into master Jan 28, 2021
@mforets mforets deleted the mforets/cleanup_issubset branch January 28, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic