Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for docs build #2489

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Increase timeout for docs build #2489

merged 3 commits into from
Jan 5, 2021

Conversation

schillic
Copy link
Member

@schillic schillic commented Jan 4, 2021

Recently we breach the 30 minutes 🤕

@schillic schillic requested a review from mforets January 4, 2021 13:07
@schillic
Copy link
Member Author

schillic commented Jan 4, 2021

Timeout (40 minutes) reached. Terminating "julia --project=docs/ docs/make.jl"

Wow, something seems to be broken... I'll try to build locally.

@schillic
Copy link
Member Author

schillic commented Jan 4, 2021

My findings: The majority of the time is spent in compiling all the methods. Apart from that, the docs build very fast (7 seconds) with two exceptions:

@mforets What do you think about removing the @btime from the docs (only takes 1 second then) and using faster parameters in the reachability algorithm? I tried δ = 0.01 (10x bigger) and that only takes 2 seconds with almost the same result.

@schillic
Copy link
Member Author

schillic commented Jan 4, 2021

I pushed a proposal. Let's look at the build time.

@mforets
Copy link
Member

mforets commented Jan 4, 2021

@mforets What do you think about removing the @Btime from the docs (only takes 1 second then) and using faster parameters in the reachability algorithm? I tried δ = 0.01 (10x bigger) and that only takes 2 seconds with almost the same result.

sounds good!

Here we use @Btime several times (I stopped it after ~10 minutes). Is this a regression?

idk, i can check too

@schillic
Copy link
Member Author

schillic commented Jan 4, 2021

26 minutes 🎉

@schillic schillic merged commit 8a7d096 into master Jan 5, 2021
@schillic schillic deleted the schillic/travis branch January 5, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants