#2277 - Overapproximate a polytope with a zonotope using cartesian decomposition #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
Jul 30, 2020
|
remains that we add some tests, and that we have #2299. |
mforets
reviewed
Jul 31, 2020
|
looks good so far. @SebastianGuadalupe can you rebase this branch and add some tests for the new function? |
SebastianGuadalupe
force-pushed
the
sguadalupe/2277
branch
from
c63826d to
9d67c14
Compare
mforets
approved these changes
Aug 5, 2020
schillic
reviewed
Aug 5, 2020
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
schillic
reviewed
Aug 5, 2020
Co-authored-by: Christian Schilling <[email protected]>
schillic
approved these changes
Aug 5, 2020
mforets
approved these changes
Aug 5, 2020
mforets
reviewed
Aug 6, 2020
|
looks good to me.. merge? @schillic |
schillic
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2277.