Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP #191] HPolygon/HPolytope conversion #227

Merged
merged 5 commits into from
Feb 10, 2018
Merged

[WIP #191] HPolygon/HPolytope conversion #227

merged 5 commits into from
Feb 10, 2018

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 8, 2018

Closes #191.

@schillic
Copy link
Member Author

schillic commented Feb 8, 2018 •
edited
Loading

@mforets: I went for a convert strategy. If you agree with this solution, I will add the documentation and also move the recent Zonotope conversion to the new file.

@mforets
Copy link
Member

mforets commented Feb 9, 2018

yes, i agree with overloading convert, as long as these conversions are straightforward and exact. if there are other complications or overapproximations i would put them on the target set's file (or in the Approximations module, e.g. overloadingoverapproximate)

mforets
mforets approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schillic
Copy link
Member Author

schillic commented Feb 10, 2018 •
edited
Loading

Where should we put the documentation? Create a new section conversion.md? I just did that.

@mforets
Copy link
Member

mforets commented Feb 10, 2018

ok, looks good!

@schillic schillic merged commit 7acccb3 into master Feb 10, 2018
@schillic schillic deleted the schillic/191 branch February 10, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets