Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#941 - Add convex_hull of an array of polytopes #2215

Merged
merged 7 commits into from
Jul 14, 2020
Merged

#941 - Add convex_hull of an array of polytopes #2215

merged 7 commits into from
Jul 14, 2020

Conversation

SebastianGuadalupe
Copy link
Member

Closes #941.

mforets
mforets approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

schillic
schillic approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if removing the kwargs was good, but fine 😃

src/ConcreteOperations/convex_hull.jl Outdated Show resolved Hide resolved
@mforets
Copy link
Member

mforets commented Jul 14, 2020

docs are green now... merging!

@mforets
Copy link
Member

mforets commented Jul 14, 2020

I am not sure if removing the kwargs was good, but fine smiley

i agree; the kwargs can be used to pass a backend for taking the convex hull, or additional options.

@mforets
Copy link
Member

mforets commented Jul 14, 2020

i agree; the kwargs can be used to pass a backend for taking the convex hull, or additional options.

@SebastianGuadalupe could you please try adding those again?

@mforets mforets merged commit ed100b0 into master Jul 14, 2020
@schillic schillic deleted the sguadalupe/941 branch July 14, 2020 17:42
@SebastianGuadalupe SebastianGuadalupe mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

convex_hull of polytopes
3 participants
@SebastianGuadalupe @mforets @schillic