Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#193 #217

Merged
merged 6 commits into from
Feb 6, 2018
Merged

#193 #217

merged 6 commits into from
Feb 6, 2018

Conversation

mforets
Copy link
Member

@mforets mforets commented Feb 5, 2018 •
edited
Loading

Closes #193.

@schillic
Copy link
Member

schillic commented Feb 5, 2018

Looks good so far. Let us use only one out of "polyhedra/polytopes".

@mforets mforets changed the title WIP #193 #193 Feb 6, 2018
@mforets
Copy link
Member Author

mforets commented Feb 6, 2018

ready to go if u approve -- i plan to work further on VPolytope and HPolytope as outlined in #155

schillic
schillic approved these changes Feb 6, 2018
View reviewed changes
src/VPolytope.jl Outdated
# constructor for a VPolytope with empty vertices list
VPolytope{N}() where {N<:Real} = VPolytope{N}(Vector{N}(0))

# constructor for a VPolytope with no constraints of type Float64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"constraints" → "vertices"

src/VPolytope.jl Outdated
"""
cartesian_product(P1::VPolytope, P2::VPolytope; [backend]=CDDLib.CDDLibrary())

Compute the Cartesian product of two polytopes in V-representaion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"representation"

src/VPolytope.jl Outdated

### Output

The `VPolytope` obtained by the concrete cartesian product of `P1` and `P2`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Cartesian"

@mforets
Copy link
Member Author

mforets commented Feb 6, 2018

thanks for the review 👍

@mforets mforets merged commit 0b56725 into master Feb 6, 2018
@schillic
Copy link
Member

schillic commented Feb 6, 2018

There is also a doctest failing: The subtypes of AbstractPolytope have changed.

@mforets mforets deleted the mforets/193 branch February 6, 2018 19:39
@mforets
Copy link
Member Author

mforets commented Feb 6, 2018

ouch, too late. i'll fix it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mforets @schillic