-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Julia v1.4 to CI #2084
Add Julia v1.4 to CI #2084
Conversation
1b0b673
to
c4fad7a
Compare
@schillic maybe this is a good moment to add v1.4 to Travis CI ? |
Sure, that is what this PR is trying to do, right? If it works I give you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming it works 😉
The doctests fail. Apparently the types of |
true, now i remember having seen this kind of error when i built docs locally with julia v1.4 here i would just revert and build docs with v1.3 |
This change will not be enough. You have to adapt the doctests. |
i thought that with this change the doctests will still be done in the julia version in which the docs are deployed (which is still v1.3). if that is not the case, i think that is what makes sense.. |
Right, we run doctests in the normal test suite. |
i agree that if we insist on doctests as a fundamental part of the test suite then we should test with all julia versions, but then we have to adapt many doctests for changes that are "non-breaking" for julia base such as changing in display format. this happened in the 0.6 to 1.0 transition too. we can otherwise make the doctests to not be required to each build. |
We test several features only in doctests. I would prefer to get informed about broken features. Also, the reported code coverage would decrease if we excluded doctests. Given the rather fundamental change (types of |
No description provided.