Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia v1.4 to CI #2084

Merged
merged 6 commits into from
May 12, 2020
Merged

Add Julia v1.4 to CI #2084

merged 6 commits into from
May 12, 2020

Conversation

mforets
Copy link
Member

@mforets mforets commented Mar 25, 2020

No description provided.

@mforets mforets force-pushed the mforets/update_travis branch from 1b0b673 to c4fad7a Compare March 25, 2020 14:36
@schillic schillic changed the title Add Julia v1.4 to CI Add support for Julia v1.4 Mar 25, 2020
@mforets
Copy link
Member Author

mforets commented May 11, 2020

@schillic maybe this is a good moment to add v1.4 to Travis CI ?

@schillic
Copy link
Member

Sure, that is what this PR is trying to do, right? If it works I give you 👍

@mforets mforets changed the title Add support for Julia v1.4 Add Julia v1.4 to CI May 11, 2020
.appveyor.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming it works 😉

@schillic
Copy link
Member

The doctests fail. Apparently the types of Vectors are not printed anymore. Note that we run doctests in the normal test suite and hence we cannot generally support different Julia versions. I think the best way to resolve this is to not print these types in doctests at all.

@mforets
Copy link
Member Author

mforets commented May 11, 2020

true, now i remember having seen this kind of error when i built docs locally with julia v1.4 here i would just revert and build docs with v1.3

@schillic
Copy link
Member

This change will not be enough. You have to adapt the doctests.

@mforets
Copy link
Member Author

mforets commented May 11, 2020

i thought that with this change the doctests will still be done in the julia version in which the docs are deployed (which is still v1.3). if that is not the case, i think that is what makes sense..

@schillic
Copy link
Member

Right, we run doctests in the normal test suite.

@mforets
Copy link
Member Author

mforets commented May 11, 2020

i agree that if we insist on doctests as a fundamental part of the test suite then we should test with all julia versions, but then we have to adapt many doctests for changes that are "non-breaking" for julia base such as changing in display format. this happened in the 0.6 to 1.0 transition too. we can otherwise make the doctests to not be required to each build.

@schillic
Copy link
Member

schillic commented May 12, 2020

if we insist on doctests as a fundamental part of the test suite

We test several features only in doctests. I would prefer to get informed about broken features. Also, the reported code coverage would decrease if we excluded doctests.

Given the rather fundamental change (types of Vectors), I agree that we need to find a feasible solution because we often want to print Vectors as results. I can try to remove the outputs (see #2151) and if it turns out to be too much we can run the doctests only in the build that we use for creating the docs. But then we should henceforth make new doctests redundant by adding similar tests in the normal test suite. This is anyway a good idea.

@mforets mforets merged commit 9e25865 into master May 12, 2020
@mforets mforets deleted the mforets/update_travis branch May 12, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants