Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2004 - Generalize vertices type in VPolytope #2012

Merged
merged 1 commit into from
Feb 29, 2020
Merged

#2004 - Generalize vertices type in VPolytope #2012

merged 1 commit into from
Feb 29, 2020

Conversation

mforets
Copy link
Member

@mforets mforets commented Feb 26, 2020

Closes #2004.

@mforets
Copy link
Member Author

mforets commented Feb 26, 2020 •
edited
Loading

tests pass locally. i opened some related follow-up PRs (#2009, #2010, #2011).

@mforets mforets requested a review from schillic February 26, 2020 20:38
@mforets
Copy link
Member Author

mforets commented Feb 28, 2020

Bump 🎺

@schillic
Copy link
Member

I already commented in #2004 that the container should also be parameterized.

schillic
schillic approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add the type parameter for the container in a follow-up PR.

@mforets
Copy link
Member Author

mforets commented Feb 29, 2020

Thanks for the review!

I will add the type parameter for the container in a follow-up PR.

As i said there, i think that the outer vector is the correct level of abstraction. For a specific case, a new set type may be better. Or we can reconsider generalizing the outer type, but for now, i think we can leave this as is..

@mforets mforets merged commit 2ceeac1 into master Feb 29, 2020
@mforets mforets deleted the mforets/2004 branch February 29, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize vertices type in VPolytope
2 participants
@mforets @schillic