Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1125 - isuniversal methods for bounded sets #1799

Merged
merged 3 commits into from
Dec 12, 2019
Merged

#1125 - isuniversal methods for bounded sets #1799

merged 3 commits into from
Dec 12, 2019

Conversation

schillic
Copy link
Member

Closes #1125.

@schillic schillic requested a review from mforets November 28, 2019 09:53
mforets
mforets reviewed Nov 28, 2019
View reviewed changes
Copy link
Member

@mforets mforets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you define being universal? Can you add this definition? I thought it was equivalent to being unbounded.

Edit: ok, it should be that it is the full space Rn.

@schillic
Copy link
Member Author

ok, it should be that it is the full space Rn.

Yes, and this is actually not a new method.

mforets
mforets approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@mforets mforets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment about non-breaking isuniversal for HPolytope() that is solved with the additional check if isempty(P.constraints). In any case, the PR LGTM.

@schillic schillic requested a review from mforets November 29, 2019 19:19
@mforets mforets mentioned this pull request Dec 12, 2019
Open
mforets
mforets requested changes Dec 12, 2019
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder for the missing change: #1799 (comment)

@schillic schillic requested a review from mforets December 12, 2019 19:28
@mforets
Copy link
Member

mforets commented Dec 12, 2019

lgtm once ci passes

@schillic schillic merged commit b1f61c3 into master Dec 12, 2019
@schillic schillic deleted the schillic/1125 branch December 12, 2019 21:32
@schillic schillic mentioned this pull request Dec 12, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add isuniversal methods for all set types
2 participants
@schillic @mforets